Skip to content

Add logs table row buttons (filters, copy as json etc.) #97545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 13, 2025
Merged

Add logs table row buttons (filters, copy as json etc.) #97545

merged 7 commits into from
Aug 13, 2025

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Aug 8, 2025

Summary

This adds some actions below the details when opening a log in the logs table.

@k-fish
Add logs table row buttons (filters, copy as json etc.)
57328fe 
This adds some actions below the details when opening a log in the logs
table.
@k-fish k-fish requested a review from a team August 8, 2025 23:28
@k-fish k-fish requested a review from a team as a code owner August 8, 2025 23:28
@linear Linear
Copy link

linear bot commented Aug 8, 2025

LOGS-135 Add button to copy raw JSON of the log

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 8, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

AbhiPrasad
AbhiPrasad approved these changes Aug 11, 2025
View reviewed changes
static/app/views/explore/logs/utils.tsx
}
}
}
return JSON.stringify(copy, null, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would user expect we return formatted json here? I'd just return JSON.stringify(copy).

Also this can throw, but I guess we can just rely on the error sentry captures to report back.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@k-fish k-fish force-pushed the feat/ourlogs/add-copy-as-json/logs-135 branch from 8ac8d43 to 57328fe Compare August 11, 2025 18:15
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11410 1 11409 10
View the top 1 failed test(s) by shortest run time 
logsTableRow copies log as JSON when Copy as JSON button is clicked
Stack Traces | 0.434s run time 
Error: expect(received).toBeDefined()

Received: undefined
    at Object.toBeDefined (.../logs/tables/logsTableRow.spec.tsx:453:58)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@k-fish k-fish enabled auto-merge (squash) August 13, 2025 14:52
@k-fish k-fish merged commit 994a5b1 into master Aug 13, 2025
46 checks passed
@k-fish k-fish deleted the feat/ourlogs/add-copy-as-json/logs-135 branch August 13, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-fish @AbhiPrasad